yulqen/bcompiler-engine
Watch
1
0
Fork
You've already forked bcompiler-engine
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

check command log message not clear if key and sheet missing #17

New issue
Closed
opened 2019-11-01 07:29:05 +00:00 by yulqen · 2 comments
yulqen commented 2019-11-01 07:29:05 +00:00 (Migrated from github.com)
Copy link

When running a check on the datamap, the check command gives an unclear CRITICAL log.

This is because a None is returned, which is unprintable. We need to replace this log message with something more user-friendly.

This happens when the key and summary are missing and when all fields are missing. This makes most sense when managing the datamap using Excel, which is the recommended method.

image

When running a check on the datamap, the `check` command gives an unclear `CRITICAL` log. This is because a `None` is returned, which is unprintable. We need to replace this log message with something more user-friendly. This happens when the key and summary are missing and when all fields are missing. This makes most sense when managing the datamap using Excel, which is the recommended method. ![image](https://user-images.githubusercontent.com/246857/68009136-0a909280-fc79-11e9-9969-6be47eccc63c.png)
yulqen commented 2019-11-01 07:29:32 +00:00 (Migrated from github.com)
Copy link

Fix check log message returning None

![](https://github.trello.services/images/mini-trello-icon.png) [Fix check log message returning None](https://trello.com/c/QPEIQQPE/9-fix-check-log-message-returning-none)
yulqen commented 2019-11-08 16:50:59 +00:00 (Migrated from github.com)
Copy link

Fixed in 77e4c3cbf7

Fixed in 77e4c3cbf7f77e83ee90e177b5d900a7a7691344
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
dependabot/pip/pytest-9.0.3
dependabot/pip/black-26.3.1
xml-parsing
v1.1.5
v1.1.4
v1.1.3
v1.1.2
v1.1.1
v1.0.9
v1.0.8
v1.0.7
template_reader_removed
lxml-tests-passing
v1.0.6
v1.0.5
v1.0.4
v1.0.3
v1.0.2
v1.0.1
v1.0.0
v0.0.3
v0.0.2
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
yulqen/bcompiler-engine#17
No description provided.