yulqen/bcompiler-engine
Watch
1
0
Fork
You've already forked bcompiler-engine
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Row limit is set to X is displayed when running non import commands #32

New issue
Closed
opened 2021-01-15 20:06:48 +00:00 by yulqen · 1 comment
yulqen commented 2021-01-15 20:06:48 +00:00 (Migrated from github.com)
Copy link

The line INFO - Row limit is set to 500 is the default log message that should be displayed when running datamaps import templates. It currently displays when running any datamaps command.

This is due to the worsening situation whereby log messages are being smeared between datamaps and bcompiler-engine. This issue demonstrates that they are being careless run between commands too.

Logging should be done at the top level preferably - in datamaps only, unless bcompiler-engine received a flag to switch on logging perhaps.

The line `INFO - Row limit is set to 500` is the default log message that should be displayed when running `datamaps import templates`. It currently displays when running any `datamaps` command. This is due to the worsening situation whereby log messages are being smeared between `datamaps` and `bcompiler-engine`. This issue demonstrates that they are being careless run between commands too. Logging should be done at the top level preferably - in `datamaps` only, unless `bcompiler-engine` received a flag to switch on logging perhaps.
yulqen commented 2021-01-16 16:08:56 +00:00 (Migrated from github.com)
Copy link

Fixed with 9febb8e.

Fixed with 9febb8e.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
dependabot/pip/pytest-9.0.3
dependabot/pip/black-26.3.1
xml-parsing
v1.1.5
v1.1.4
v1.1.3
v1.1.2
v1.1.1
v1.0.9
v1.0.8
v1.0.7
template_reader_removed
lxml-tests-passing
v1.0.6
v1.0.5
v1.0.4
v1.0.3
v1.0.2
v1.0.1
v1.0.0
v0.0.3
v0.0.2
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
v1.1.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
yulqen/bcompiler-engine#32
No description provided.