yulqen/bcompiler-engine
Watch
1
0
Fork
You've already forked bcompiler-engine
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Ensure that validation report reports on empty cells #33

New issue
Closed
opened 2021-01-15 20:52:31 +00:00 by yulqen · 2 comments
yulqen commented 2021-01-15 20:52:31 +00:00 (Migrated from github.com)
Copy link

Here is my TODO from engine.use_cases.parsing (circa line 90) before resetting:

 # TODO
    #
    # When importing from a template, if the cell is empty, it passes as an
    # empty value to the master. Fine.

    # Currently the validation report does not catch cells that are empty in
    # the populated template. An example is "Controls Project ID number"
    # from the datamap in dft_all_files_for_million_row_issue30.zip Q3 datamap.
    #
    # That is the result of only doing the vtype stuff below if c == cellref..
    # In other words, no empty cells from the populated template go into the
    # validation report. And we probably want that.
Here is my TODO from `engine.use_cases.parsing` (circa line 90) before resetting: ``` # TODO # # When importing from a template, if the cell is empty, it passes as an # empty value to the master. Fine. # Currently the validation report does not catch cells that are empty in # the populated template. An example is "Controls Project ID number" # from the datamap in dft_all_files_for_million_row_issue30.zip Q3 datamap. # # That is the result of only doing the vtype stuff below if c == cellref.. # In other words, no empty cells from the populated template go into the # validation report. And we probably want that. ```
yulqen commented 2021-01-16 17:24:47 +00:00 (Migrated from github.com)
Copy link

Fixed with 69e38c4bab.

Fixed with 69e38c4bab2d05020c44e45f8deacfaa010d5483.
yulqen commented 2021-01-17 16:51:37 +00:00 (Migrated from github.com)
Copy link

Currently, if a dml is not typed and the value is empty, validation reports it as a FAIL. It should be UNTYPED.

Currently, if a dml is not typed and the value is empty, validation reports it as a FAIL. It should be UNTYPED.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
dependabot/pip/pytest-9.0.3
dependabot/pip/black-26.3.1
xml-parsing
v1.1.5
v1.1.4
v1.1.3
v1.1.2
v1.1.1
v1.0.9
v1.0.8
v1.0.7
template_reader_removed
lxml-tests-passing
v1.0.6
v1.0.5
v1.0.4
v1.0.3
v1.0.2
v1.0.1
v1.0.0
v0.0.3
v0.0.2
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
v1.1.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
yulqen/bcompiler-engine#33
No description provided.