Xlsm file requirement for blank_template

banillie commented

2021-11-01 15:47:23 +00:00

(Migrated from github.com)

At the moment for export blank_template needs to be an xlsm file. Would be possible to handle xlsx files also?
Thanks.

At the moment for export blank_template needs to be an xlsm file. Would be possible to handle xlsx files also? Thanks.

yulqen commented

2021-11-01 20:41:42 +00:00

(Migrated from github.com)

I guess so. If I remember, the reason for using "xlsm" files was because the
template contained macros. Not sure why "xlsx" files weren't enabled also.
What's your timescale?

On 01-11-2021, Will Grant wrote:

At the moment for export blank_template needs to be an xlsm file. Would be possible to handle xlsx files also?
Thanks.

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/yulqen/datamaps/issues/21

--

Matthew Lemon
Email: @.***

I guess so. If I remember, the reason for using "xlsm" files was because the template contained macros. Not sure why "xlsx" files weren't enabled also. What's your timescale? On 01-11-2021, Will Grant wrote: >At the moment for export blank_template needs to be an xlsm file. Would be possible to handle xlsx files also? >Thanks. > >-- >You are receiving this because you are subscribed to this thread. >Reply to this email directly or view it on GitHub: >https://github.com/yulqen/datamaps/issues/21 -- Matthew Lemon Email: ***@***.***

banillie commented

2021-11-02 09:38:50 +00:00

(Migrated from github.com)

No timescale really. Whenever's good for you. Cheers.

yulqen commented

2021-11-02 16:48:27 +00:00

(Migrated from github.com)

As far as I can tell, xlsx files are imported fine (datamaps import templates -d datamap.csv -m --inputdir . for example).

export creates xlsm files from a master but these can just be re-saved as
xlsx files if you wish.

As far as I recall, we wanted the blank_template file to be macro-enabled for
some reason - are you saying that you want these exported files to be xlsx
files now, or do you want the choice?

Be good to get a more detailed scenario or the problem you are facing/the exact params you'd like to see
in the Issue! We can discuss later in the week of course.

As far as I can tell, `xlsx` files are imported fine (`datamaps import templates -d datamap.csv -m --inputdir .` for example). `export` creates `xlsm` files from a master but these can just be re-saved as `xlsx` files if you wish. As far as I recall, we wanted the `blank_template` file to be macro-enabled for some reason - are you saying that you want these exported files to be `xlsx` files now, or do you want the choice? Be good to get a more detailed scenario or the problem you are facing/the exact params you'd like to see in the Issue! We can discuss later in the week of course.

banillie commented

2021-11-03 08:34:28 +00:00

(Migrated from github.com)

Ok thanks. I'll look into this further with the team and get back to you.

banillie commented

2021-11-04 12:48:57 +00:00

(Migrated from github.com)

Hiya, re the above it would be good if the datamaps export command could simply handle both .xlsm and .xlsx files. This is a because the team is using datamaps for another data gathering bit of work which doesn't need an .xlsm file (only a simple xlsx).

yulqen commented

2021-11-04 13:25:30 +00:00

(Migrated from github.com)

Ok.

Options for implementation

(Note to self: point at where decision is made is in
bcompiler-engine.repository.templates:93.) Just thinking out loud here.

cmd line param to set desired file type in datamaps (datamaps.main:329).
Handle in bcompiler-engine.adapters.cli:89.
Actually, it would be simpler/clearer if the output format matched the blank
template, with no further config or user intervention. Then all code could
be handled inside MultipleTemplatesWriteRepo.

Ok. ## Options for implementation (Note to self: point at where decision is made is in `bcompiler-engine.repository.templates:93`.) Just thinking out loud here. 1. cmd line param to set desired file type in `datamaps` (`datamaps.main:329`). 1. Handle in `bcompiler-engine.adapters.cli:89`. 1. Actually, it would be simpler/clearer if the output format matched the blank template, with no further config or user intervention. Then all code could be handled inside `MultipleTemplatesWriteRepo`.

yulqen commented

2021-11-05 14:36:07 +00:00

(Migrated from github.com)

@banillie - Would you be content for the file type of the exported spreadsheets to match that of the template? In other words, if the blank template file is xlsx, the exported templates will be xlsx also? This is considerably more straightforward than adding a new command line option which allows the user to choose the output format and would be my preference in terms of simplcity. Happy to implement the command line flag option but it will take a bit longer.

@banillie - Would you be content for the file type of the exported spreadsheets to match that of the template? In other words, if the blank template file is `xlsx`, the exported templates will be `xlsx` also? This is considerably more straightforward than adding a new command line option which allows the user to choose the output format and would be my preference in terms of simplcity. Happy to implement the command line flag option but it will take a bit longer.

banillie commented

2021-11-06 16:11:36 +00:00

(Migrated from github.com)

Yes absolutely. Simply output the same file format. I think that makes more sense in terms of design anyway. Cheers.

yulqen commented

2023-03-25 18:13:07 +00:00

(Migrated from github.com)

Wow - I need to do this.

Rows
Columns

Xlsm file requirement for blank_template #21

Options for implementation