option to specify datamap document

banillie commented

2020-05-08 18:53:31 +00:00

(Migrated from github.com)

Hi Matt, it would be good if there was some optionality to specify which datamap should be used in the command. You may recall that we actually use one version of the datamap for export and another version for import. It would be handy if we could specify in the command which datamap should be used. Just a thought. Hope you're enjoying the long weekend.
Cheers, Will.

Hi Matt, it would be good if there was some optionality to specify which datamap should be used in the command. You may recall that we actually use one version of the datamap for export and another version for import. It would be handy if we could specify in the command which datamap should be used. Just a thought. Hope you're enjoying the long weekend. Cheers, Will.

yulqen commented

2020-05-08 19:46:21 +00:00

(Migrated from github.com)

I'll have a look at that. Great suggestion!

😆 1

yulqen commented

2020-05-15 15:15:11 +00:00

(Migrated from github.com)

Implemented option to specify datamap in import in a962f9411e and github.com/hammerheadlemon/bcompiler-engine@ae1177a48e.

Will take the form - both are equivalent:

datamaps import templates -m -d "/path/to/datamap_alterative.csv" and
datamaps import templates -m --datamap "/path/to/datamap_alterative.csv"

Working on export next. Will soon be ready for testing if you are able?

Implemented option to specify datamap in `import` in a962f9411eab9f0e55620b8c686279edc254ccc0 and https://github.com/hammerheadlemon/bcompiler-engine/commit/ae1177a48ef944d05a09d4358486bf3ab4629a39. Will take the form - both are equivalent: `datamaps import templates -m -d "/path/to/datamap_alterative.csv"` and `datamaps import templates -m --datamap "/path/to/datamap_alterative.csv"` Working on `export` next. Will soon be ready for testing if you are able?

banillie commented

2020-05-15 18:27:40 +00:00

(Migrated from github.com)

Yes certainly. 👍

Yes certainly. :+1:

👍 1

yulqen commented

2020-05-17 11:03:42 +00:00

(Migrated from github.com)

Morning @banillie!

When you have a moment, can you please test the updated version of datamaps which now incorporates this feature.

In your terminal:

python -m venv /tmp/dmtest
source /tmp/dmtest/bin/activate
pip install datamaps
pip list - you should have 1.0.5 or both datamaps and bcompiler-engine.
datamaps import templates --help - you should see new -d flag.
datamaps export master --help - you should see new -d flag.

Test!

When you're done you can raze the virtualenv with deactivate then rm -r /tmp/dmtest.

Let me know all feedback. Good luck.

I will build the Windows exe file once we're happy.

Morning @banillie! When you have a moment, can you please test the updated version of datamaps which now incorporates this feature. In your terminal: `python -m venv /tmp/dmtest` `source /tmp/dmtest/bin/activate` `pip install datamaps` `pip list` - you should have `1.0.5` or both `datamaps` and `bcompiler-engine`. `datamaps import templates --help` - you should see new `-d` flag. `datamaps export master --help` - you should see new `-d` flag. Test! When you're done you can raze the virtualenv with `deactivate` then `rm -r /tmp/dmtest`. Let me know all feedback. Good luck. I will build the Windows exe file once we're happy.

😆 1

banillie commented

2020-05-17 18:16:13 +00:00

(Migrated from github.com)

Excellent. Will try and test tonight @hammerheadlemon 👍

👍 1

banillie commented

2020-05-17 21:15:54 +00:00

(Migrated from github.com)

Hiya Matt all tested and working successfully. Should make handling the different datasets required for import and export much easier in the future. Great stuff. Congratulations.

yulqen commented

2020-05-17 21:27:55 +00:00

(Migrated from github.com)

Awesome. Thanks for checking so quickly. Let me know if you hit any problems.

banillie commented

2020-05-18 06:16:46 +00:00

(Migrated from github.com)

Thank you for re-coding and closing this improvement so quickly.

Rows
Columns

option to specify datamap document #7